[FIX] stock_picking_batch_validate_confirm: avoid propagating context with defaults #1870
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @rafaelbn, @EmilioPascual, |
… with defaults When this module was installed along with `sale_elaboration`, elaboration sale order lines could be created automatically when confirming a picking. The `sale.order.line` model also has a `move_ids` field. Thus, those lines were created associated to the `stock.move` records found from within the batch. To make it even more fun, a batch can contain moves associated to unrelated sales. Thus, the elaboration lines were getting stock moves (which is wrong because they are services) and those moves came from unrelated sale orders. This mismatch was resulting in unexpected behaviors here and there. Now, we just produce defaults based on the standard context that all wizards get by default. This is safe and doesn't pollute any sub-calls. @moduon MT-9033 MT-7490
yajo
force-pushed
the
16.0-spbvc-fix_elaboration_compat
branch
from
95c532a to
2a687be
Compare
|
/ocabot merge patch |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at aca7f45. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When this module was installed along with
sale_elaboration, elaboration sale order lines could be created automatically when confirming a picking.The
sale.order.linemodel also has amove_idsfield. Thus, those lines were created associated to thestock.moverecords found from within the batch.To make it even more fun, a batch can contain moves associated to unrelated sales. Thus, the elaboration lines were getting stock moves (which is wrong because they are services) and those moves came from unrelated sale orders.
This mismatch was resulting in unexpected behaviors here and there.
Now, we just produce defaults based on the standard context that all wizards get by default. This is safe and doesn't pollute any sub-calls.
@moduon MT-9033 MT-7490